Comprehensive spec (#19)

* core: fix jolt-265 — syntax-quote fully-qualifies core syms to clojure.core/

Re-attempt of the deferred gap, now unblocked. The earlier uberscript break
wasn't qualification itself but an aliased-ref resolution bug it exposed:
resolve-var looked up ns-aliases (e.g. g/foo) against the analyzer's REBOUND
ctx-current-ns (jolt.analyzer, since the analyzer runs interpreted in its own
ns) instead of the namespace being compiled. A user's aliased refs failed
mid-compile (g/hello -> nil in the bundled standalone).

- resolve-var resolves aliases against :compile-ns when set (same ns
  h-current-ns uses), falling back to ctx-current-ns — correct for both modes.
- sq-symbol qualifies a resolved clojure.core name to clojure.core/<name>
  (Clojure hygiene); special forms stay bare; unresolved syms -> current ns.

Tests updated to the qualified behavior (features-test, reader-forms-spec).

* test: comprehensive spec — regex + sorted colls + random/predicate gaps

Filling the biggest untested clojure.core areas found in a coverage audit
(168 of 506 provided fns had no spec). New + expanded suites:

- regex-spec.janet (20): #"…" literals, regex?, re-find/re-matches/re-seq
  (match/no-match/groups), re-pattern, and clojure.string split/replace with
  regex (incl $1 backrefs). Whole area was previously unspecced.
- sorted-spec.janet (14): sorted-map/sorted-set construction + ordering, sorted?,
  subseq/rsubseq. Pins the working subset — get/conj/assoc/keys/vals on sorted
  colls and the by-comparator ctors are not yet first-class (jolt-ti9).
- predicates-spec +14: seqable?, integer?, reduced?/unreduced, not-empty.
- numbers-spec +5: rand/rand-int/rand-nth invariants.

Fix: sorted? was bound to core-sorted-map? so it returned false for sorted-sets;
now true for both sorted maps and sets (core-sorted?).

Filed: jolt-ti9 (sorted collections incomplete: get/conj/assoc/keys/vals don't
operate on the sorted wrapper; sorted-*-by ignore the comparator).

Gate green incl full jpm build + jpm test.

* core: close surfaced gaps — first-class sorted colls, with-out-str, rand arity, deref reduced

jolt-ti9: sorted-map/sorted-set are now first-class across the collection fns —
get/assoc/dissoc/conj/contains?/keys/vals/disj and call-as-fn all operate on the
wrapper and preserve sort order. The by-comparator constructors (sorted-map-by/
sorted-set-by) now thread the user comparator (numeric or boolean-predicate) through
all derived colls. Sorted predicates/ctors/ops moved above core-conj so the
collection fns can branch on them; jolt-invoke (interpreter) gets inline branches.

jolt-rfw: add with-out-str (binds output to a string buffer) + the macro.
jolt-ek3: (rand n) arity and deref-of-reduced (uuid? still deferred).

Specs: new io-spec.janet; sorted-spec expanded to pin the now-working map/set ops
and by-comparator ordering; predicate/number spec restorations.

* remove old doc

* core: fix stale comment — by-comparator sorted ctors are implemented

---------

Co-authored-by: Yogthos <yogthos@gmail.com>
This commit is contained in:
Dmitri Sotnikov 2026-06-10 20:33:22 +08:00 committed by GitHub
parent afb7d17352
commit 3e9fe8d0fb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 254 additions and 462 deletions

26
test/spec/io-spec.janet Normal file
View file

@ -0,0 +1,26 @@
# Specification: printing / output (print/println/pr/prn, *-str, format, str).
# Output is captured with with-out-str (jolt-rfw); the *-str fns return strings.
(use ../support/harness)
(defspec "io / with-out-str captures"
["println" "\"hi\\n\"" "(with-out-str (println \"hi\"))"]
["print spaces" "\"a b\"" "(with-out-str (print \"a\" \"b\"))"]
["prn quotes" "\"[1 2]\\n\"" "(with-out-str (prn [1 2]))"]
["pr no newline" "\"5\"" "(with-out-str (pr 5))"]
["multiple writes" "\"12\"" "(with-out-str (print 1) (print 2))"]
["no output" "\"\"" "(with-out-str 42)"]
["println no args" "\"\\n\"" "(with-out-str (println))"])
(defspec "io / *-str builders"
["print-str" "\"a b\"" "(print-str \"a\" \"b\")"]
["println-str" "\"x\\n\"" "(println-str \"x\")"]
["prn-str" "\"[1 2]\\n\"" "(prn-str [1 2])"]
["pr-str quotes" "\"\\\"s\\\"\"" "(pr-str \"s\")"]
["pr-str keyword" "\":a\"" "(pr-str :a)"])
(defspec "io / str & format"
["str concat" "\"1:ab\"" "(str 1 :a \"b\")"]
["str nil" "\"\"" "(str nil)"]
["str of coll" "\"[1 2]\"" "(str [1 2])"]
["format d/s" "\"5-x\"" "(format \"%d-%s\" 5 \"x\")"]
["format float" "\"3.14\"" "(format \"%.2f\" 3.14159)"])