*unchecked-math* on macro-emitted arithmetic + local shadowing a bare native op
Two general fixes shaken out by clojure.test.check's own suite (its splittable PRNG mixes 64-bit longs and binds locals named min/max). - *unchecked-math* now wraps arithmetic a macro emits. The analyzer rewrote a bare (+/-/*) to its wrapping unchecked-* under *unchecked-math*, but a macro's syntax-quote produces clojure.core/* (qualified), which was skipped — so e.g. test.check's mix-64 multiply grew to a bignum instead of a 64-bit long. The rewrite now also fires on the clojure.core-qualified form. - A local binding named like a bare-emitted native op no longer shadows it. ops where native-ops maps the name to itself (+ - * / < > min max …) emit as the bare Scheme name; a local `max` emitted the same token, so (fn [max] (clojure.core/max …)) called the param. munge-name now prefixes such locals, like reserved words (derived from native-ops so they can't drift). make test green (+1 corpus row, 0 new divergences), shakesmoke byte-identical. One re-mint (analyzer + backend).
This commit is contained in:
parent
75652de1ad
commit
992fc0af34
5 changed files with 131 additions and 114 deletions
|
|
@ -3381,4 +3381,5 @@
|
|||
{:suite "host-interop / Compiler" :label "Compiler/specials keys include the special forms" :expected "true" :actual "(every? (set (keys clojure.lang.Compiler/specials)) (quote [if do let* fn* quote def loop* recur try letfn* var]))"}
|
||||
{:suite "macros / letfn mutual recursion" :label "letfn binds mutually-recursive named fns" :expected "[true false]" :actual "(letfn [(ev? [n] (if (zero? n) true (od? (dec n)))) (od? [n] (if (zero? n) false (ev? (dec n))))] [(ev? 10) (ev? 7)])"}
|
||||
{:suite "host-interop / extend-protocol IPersistentList" :label "a protocol extended to IPersistentList dispatches on a list, not a vector" :expected "[:list :vec :list]" :actual "(do (defprotocol PL (m [x])) (extend-protocol PL clojure.lang.IPersistentList (m [_] :list) clojure.lang.IPersistentVector (m [_] :vec)) [(m (list 1 2)) (m [1 2]) (m ())])"}
|
||||
{:suite "scope / qualified ref vs same-named local" :label "clojure.core/max wins over a local named max" :expected "[10 5]" :actual "[((fn [max] (clojure.core/max 5 10)) 100) ((fn [min] (clojure.core/min 5 10)) 0)]"}
|
||||
]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue