core: move last/butlast to the Clojure overlay

Continue the kernel shrink. last/butlast become canonical Clojure defs
(pure first/next/loop/recur) in the core.clj overlay, dropping two
realize-for-iteration uses from the Janet kernel.

second was the obvious next candidate but can't move: the self-hosted
compiler front-end (analyzer.clj) calls it, and the compiler has to
compile the overlay, so anything it uses must already exist as a Janet
primitive. Documented that as a third clause of the safe-to-move rule.

Suite green, clojure-test-suite battery holds 3913 pass / 58 clean,
binary builds and runs the embedded overlay.
This commit is contained in:
Yogthos 2026-06-06 12:08:00 -04:00
parent c8810ee4aa
commit a6f0f8a6fe
2 changed files with 22 additions and 11 deletions

View file

@ -6,8 +6,26 @@
;; of the remaining Janet primitives move here from core.janet, one at a time,
;; each compiled by the prior stage. Anything here must depend only on core vars
;; already interned by init-core! (and on other overlay fns defined above it).
;;
;; Safe-to-move rule: a fn can move here only if it is (1) NOT in
;; compiler/core-renames (that map emits core-X Janet symbols directly), (2) has
;; no internal Janet callers of its core-X binding, and (3) is NOT used by the
;; self-hosted compiler itself (jolt-core/jolt/*.clj) — the compiler has to
;; compile this overlay, so anything it calls must already exist as a Janet
;; primitive. (That last rule is why `second`, used by analyzer.clj, stays in
;; Janet even though it has no Janet callers.)
(defn ffirst [coll] (first (first coll)))
(defn nfirst [coll] (next (first coll)))
(defn fnext [coll] (first (next coll)))
(defn nnext [coll] (next (next coll)))
;; Canonical Clojure defs: pure first/next/loop/recur, no Janet realize-for-iteration.
(defn last [s]
(if (next s) (recur (next s)) (first s)))
(defn butlast [s]
(loop [ret [] s s]
(if (next s)
(recur (conj ret (first s)) (next s))
(seq ret))))