Reader: #() params survive syntax-quote (auto-gensym names)
#(...) named its synthesized params with bare gensyms, so a #() written inside a syntax-quote had its params qualified to the current ns by sq-symbol — and a qualified symbol isn't a valid fn param. hiccup's compiler emits `(let [sb# ..] (iterate! #(.append sb# %) ..)), which broke with "Unable to resolve symbol: ns/_NNNN". Name the params with a trailing # (auto-gensym suffix, like Clojure's p1__N#) so syntax-quote maps them consistently and leaves them unqualified. Harmless outside a backtick (just a regular symbol name).
This commit is contained in:
parent
d223f40c91
commit
c22b23fb51
3 changed files with 20 additions and 3 deletions
|
|
@ -125,6 +125,11 @@ checks → UNVERIFIED (rows to add).
|
|||
nested form including vector, map and set literals — `#(assoc {} :k %)`,
|
||||
`#(hash-set % %2)` and `#(get {:t %} :t)` all see their `%`s. (A reader that
|
||||
scanned only call forms would miscompile `#(identity {:text %})` as a 0-arg fn.)
|
||||
- The synthesized parameters are auto-gensyms (their names carry the `#` suffix,
|
||||
like Clojure's `p1__N#`), so an `#()` written inside a syntax-quote survives:
|
||||
the params are mapped consistently and left unqualified rather than being
|
||||
qualified to the current namespace (a qualified symbol is not a valid
|
||||
parameter). E.g. `` `(map #(inc %) xs) `` expands correctly inside a macro.
|
||||
- `#()` literals MUST NOT nest.
|
||||
|
||||
```clojure
|
||||
|
|
|
|||
|
|
@ -448,10 +448,15 @@
|
|||
nil))
|
||||
(scan-pct form)
|
||||
# One canonical gensym per slot 1..max-n (placeholders for unused), plus rest.
|
||||
# Param names carry a trailing `#` (auto-gensym suffix, matching Clojure's
|
||||
# `p1__N#`) so a #() written inside a syntax-quote survives: sq-symbol treats
|
||||
# `#`-suffixed names as auto-gensyms (mapped consistently, left unqualified)
|
||||
# rather than qualifying them to the current ns — a qualified symbol is not a
|
||||
# valid fn param. Harmless outside a backtick (just a regular symbol name).
|
||||
(def slot-syms @{})
|
||||
(var i 1)
|
||||
(while (<= i max-n) (put slot-syms i (sym (string (gensym)))) (++ i))
|
||||
(def rest-sym (if has-rest (sym (string (gensym))) nil))
|
||||
(while (<= i max-n) (put slot-syms i (sym (string (gensym) "#"))) (++ i))
|
||||
(def rest-sym (if has-rest (sym (string (gensym) "#")) nil))
|
||||
# Pass 2: replace each %-symbol with its slot's gensym.
|
||||
(defn- replace-pct [f]
|
||||
(cond
|
||||
|
|
|
|||
|
|
@ -24,7 +24,14 @@
|
|||
["gensym unique" "false"
|
||||
"(= (gensym) (gensym))"]
|
||||
["gensym# in template" "true"
|
||||
"(do (defmacro m [] `(let [x# 1] x#)) (= 1 (m)))"])
|
||||
"(do (defmacro m [] `(let [x# 1] x#)) (= 1 (m)))"]
|
||||
# An #() lambda written inside a syntax-quote: its generated params must not be
|
||||
# qualified to the ns (a qualified symbol is not a valid param). hiccup's
|
||||
# compiler emits `(let [sb# ..] (run! #(.append sb# %) ..)) (jolt-nkx).
|
||||
["#() inside syntax-quote" "[2 4 6]"
|
||||
"(do (defmacro m [] `(mapv #(* % 2) [1 2 3])) (m))"]
|
||||
["#() + auto-gensym share in template" "\"ab\""
|
||||
"(do (defmacro m [] `(let [sb# (StringBuilder.)] (mapv #(.append sb# %) [\"a\" \"b\"]) (.toString sb#))) (m))"])
|
||||
|
||||
# Core macros ported from Janet to the Clojure overlay (jolt-1j0 phase 3,
|
||||
# jolt-core/clojure/core/30-macros.clj).
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue