Migrate clojure.core/set from a native shim to the kernel overlay tier
set was a native shim (apply jolt-hash-set (seq->list coll)). It is a pure composition, so the Clojure version (apply hash-set (seq coll)) lowers to the same code. The compiler uses set, but only off the emit path (the backend's bare-native-names def and type inference), so it can live in the kernel tier: compiling that tier never calls set, and by the time those callers run the tier is already bound. This is distinct from boolean, which the backend calls for every :if node on the emit path. Moving boolean even to the kernel tier deadlocks (compiling the tier that defines boolean needs boolean), so boolean stays native. Added a comment in predicates.ss recording that. Re-mint converges in 3 passes and the benchmark suite is unchanged within noise (collections 43.3 vs 43.1, binary-trees 367 vs 367, the rest flat).
This commit is contained in:
parent
3d0cbed3c5
commit
d77b4e6420
5 changed files with 310 additions and 298 deletions
|
|
@ -11,9 +11,9 @@
|
|||
(define (jolt-array-map . kvs) (jolt-array-map-build kvs))
|
||||
(define (jolt-hash-map-fn . kvs) (jolt-hash-map-build kvs))
|
||||
|
||||
;; set: realize any seqable to a list, then dedup through the set ctor. nil -> #{}.
|
||||
(define (jolt-set coll)
|
||||
(if (jolt-nil? coll) (jolt-hash-set) (apply jolt-hash-set (seq->list coll))))
|
||||
;; set lives in the kernel overlay tier (clojure/core/00-kernel.clj): it's a pure
|
||||
;; composition (apply hash-set (seq coll)) the compiler uses only off the emit path,
|
||||
;; so the Clojure version lowers to the same code without a bootstrap cycle.
|
||||
|
||||
;; rand: a flonum in [0, n) (n defaults to 1.0) — jolt is all-flonum, so the
|
||||
;; result is a double like every other number.
|
||||
|
|
@ -24,6 +24,5 @@
|
|||
(def-var! "clojure.core" "hash-map" jolt-hash-map-fn)
|
||||
(def-var! "clojure.core" "hash-set" jolt-hash-set)
|
||||
(def-var! "clojure.core" "array-map" jolt-array-map)
|
||||
(def-var! "clojure.core" "set" jolt-set)
|
||||
(def-var! "clojure.core" "rand" jolt-rand)
|
||||
(def-var! "clojure.core" "map-entry?" jolt-map-entry?)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue