simon/jolt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Emit Janet's in as a value so a user local can't shadow it (jolt-fjb1)

Browse source 
The back end emits `in` to deref var cells ((in cell :root)) and index
shape-recs. It emitted the bare symbol, so a user local named `in` shadowed
Janet's builtin in the surrounding scope and the generated cell-deref called the
user's value as a function — "<table> called with 2 arguments, possibly expected
1". malli's explainer binds [value in acc], so m/explain hit this on every
schema (m/validate was unaffected — its path doesn't bind `in`).

Embed `in`'s function value at the emit sites (as jolt-call/core-get already
are); a value in head position can't be shadowed. Fixes m/explain on malli
(loaded with JOLT_FEATURES=clj so its .cljc reader-conditionals resolve).
This commit is contained in:
Yogthos 2026-06-15 12:26:56 -04:00
parent 93c86c20f7
commit e3003ea86f
2 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/spec/functions-spec.janet
View file

@ -11,7 +11,13 @@
["variadic with fixed" "[1 [2 3]]" "(do (defn f [a & xs] [a xs]) (f 1 2 3))"]
["closure captures" "8" "(do (defn adder [n] (fn [x] (+ x n))) ((adder 5) 3))"]
["recursion" "120" "(do (defn fact [n] (if (< n 2) 1 (* n (fact (dec n))))) (fact 5))"]
["named fn self-ref" "120" "((fn fact [n] (if (< n 2) 1 (* n (fact (dec n))))) 5)"])
["named fn self-ref" "120" "((fn fact [n] (if (< n 2) 1 (* n (fact (dec n))))) 5)"]
# A param whose name collides with a Janet builtin the back end emits in
# generated code (here `in`, used to deref vars / index shape-recs) must not
# shadow it — malli's explainer binds `[value in acc]` (jolt-fjb1).
["param named `in`" "1" "((fn [in] (first in)) [1 2 3])"]
["param `in` via core fn" "3" "((fn [in] (count in)) [1 2 3])"]
["local `in` in let body" "2" "(let [in [2 3]] (first in))"])
(defspec "functions / application"
["apply" "6" "(apply + [1 2 3])"]