defmethod auto-create copies clojure.core dispatch (fix SCI regression)
The prior fix resolved an unqualified defmethod to clojure.core's multifn, which broke SCI (it relies on per-ns shadow multimethods — hung loading core_protocols). Keep the shadow, but when auto-creating it copy the dispatch fn + default from a same-named clojure.core multifn (e.g. print-method's 2-arg dispatch) instead of the 1-arg identity that crashed (print-method x w). Also trim the FQN class tokens to value classes only (the collection interfaces shadowed names SCI uses). Corpus 2705/2741 0 new div; SCI 162/218 restored; cross-ns + direct print-method overrides work.
This commit is contained in:
parent
bb6c9eeb29
commit
e3674d17a7
2 changed files with 17 additions and 20 deletions
|
|
@ -55,13 +55,11 @@
|
|||
;; fully-qualified canonical class names self-evaluate to their own name string,
|
||||
;; so (= (class 1) java.lang.Long) and (instance? clojure.lang.Atom x) resolve the
|
||||
;; class token (= what jolt-class / instance-check key on).
|
||||
;; Value classes only — NOT the collection interfaces (ISeq/IPersistentMap/...),
|
||||
;; which downstream code (e.g. SCI) references as protocols/interfaces.
|
||||
(for-each
|
||||
(lambda (nm) (def-var! "clojure.core" nm nm))
|
||||
'("java.lang.Long" "java.lang.Integer" "java.lang.Double" "java.lang.Float"
|
||||
"java.lang.Number" "java.lang.String" "java.lang.Boolean" "java.lang.Character"
|
||||
"java.lang.Object" "java.lang.CharSequence" "java.lang.Comparable"
|
||||
"clojure.lang.Keyword" "clojure.lang.Symbol" "clojure.lang.Ratio" "clojure.lang.BigInt"
|
||||
"clojure.lang.Atom" "clojure.lang.IFn" "clojure.lang.Fn" "clojure.lang.ISeq"
|
||||
"clojure.lang.IPersistentMap" "clojure.lang.IPersistentVector" "clojure.lang.IPersistentCollection"
|
||||
"clojure.lang.PersistentVector" "clojure.lang.Var" "clojure.lang.Namespace"
|
||||
"clojure.lang.MapEntry"))
|
||||
"java.lang.Object"
|
||||
"clojure.lang.Keyword" "clojure.lang.Symbol" "clojure.lang.Ratio" "clojure.lang.Atom"))
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue