09532dac05
Real transient correctness gaps surfaced by the clojure-test-suite: - Transients are now invokable for read-only lookup like their persistent forms: ((transient v) i), ((transient m) k [default]), (:k (transient m)), ((transient s) x). jolt-invoke/coll-lookup gained a transient branch (transient-lookup) that indexes :arr / canon-keyed :tbl. Added phm/canon as a public canonicalizer so collection keys compare by value here too. - assoc! accepts an ODD arg count (a missing final value is nil), unlike assoc — core-assoc! now uses nil-safe get for the value instead of erroring. - Using a transient after persistent! (or a second persistent!, or pop! on an empty transient vector) now throws, via a :jolt/persistent invalidation flag checked by the mutating ops. Catches the classic transient footgun. spec: transients-spec gains invokable-lookup (7), assoc!-odd-args (4), invalidation (4). clojure-test-suite pass 1704->1719. Remaining transient fails are accepted lenient divergences (jolt doesn't throw on bad-shape conj!/assoc!/pop! of wrong-typed args; nil set elements). jpm test green.
78 lines
4.7 KiB
Text
78 lines
4.7 KiB
Text
# Specification: transients (mutable scratch collections frozen by persistent!).
|
|
(use ../support/harness)
|
|
|
|
(defspec "transient / vector"
|
|
["conj! then persistent!" "[1 2]" "(persistent! (conj! (conj! (transient []) 1) 2))"]
|
|
["reduce conj!" "[0 1 2 3 4]" "(persistent! (reduce conj! (transient []) (range 5)))"]
|
|
["conj! many args" "[1 2 3]" "(persistent! (conj! (transient [1]) 2 3))"]
|
|
["assoc! existing" "[1 9 3]" "(persistent! (assoc! (transient [1 2 3]) 1 9))"]
|
|
["assoc! at count grows" "[1 2 3]" "(persistent! (assoc! (transient [1 2]) 2 3))"]
|
|
["pop!" "[1 2]" "(persistent! (pop! (transient [1 2 3])))"]
|
|
["from existing vector" "[1 2 3 4]" "(persistent! (conj! (transient [1 2 3]) 4))"]
|
|
["count" "3" "(count (transient [1 2 3]))"]
|
|
["nth" "2" "(nth (transient [1 2 3]) 1)"]
|
|
["get" "2" "(get (transient [1 2 3]) 1)"]
|
|
["persistent! is a vector" "true" "(vector? (persistent! (transient [1])))"]
|
|
["transient? true" "true" "(transient? (transient []))"]
|
|
["transient? false" "false" "(transient? [1 2])"])
|
|
|
|
(defspec "transient / map"
|
|
["assoc! then persistent!" "{:a 1, :b 2}" "(persistent! (assoc! (assoc! (transient {}) :a 1) :b 2))"]
|
|
["assoc! many" "{:a 1, :b 2}" "(persistent! (assoc! (transient {}) :a 1 :b 2))"]
|
|
["dissoc!" "{:b 2}" "(persistent! (dissoc! (transient {:a 1 :b 2}) :a))"]
|
|
["conj! map entry" "{:a 1}" "(persistent! (conj! (transient {}) [:a 1]))"]
|
|
["from existing map" "{:a 1, :b 2}" "(persistent! (assoc! (transient {:a 1}) :b 2))"]
|
|
["get" "1" "(get (transient {:a 1}) :a)"]
|
|
["get missing default" ":x" "(get (transient {:a 1}) :z :x)"]
|
|
["contains?" "true" "(contains? (transient {:a 1}) :a)"]
|
|
["count" "2" "(count (transient {:a 1 :b 2}))"]
|
|
["collection key by value" ":v" "(get (persistent! (assoc! (transient {}) [1 2] :v)) [1 2])"]
|
|
["persistent! is a map" "true" "(map? (persistent! (transient {:a 1})))"]
|
|
["reduce build" "{0 0, 1 1, 2 2}" "(persistent! (reduce (fn [t i] (assoc! t i i)) (transient {}) (range 3)))"])
|
|
|
|
(defspec "transient / set"
|
|
["conj! dedups" "#{1 2 3}" "(persistent! (conj! (transient #{}) 1 2 2 3))"]
|
|
["disj!" "#{1 3}" "(persistent! (disj! (transient #{1 2 3}) 2))"]
|
|
["from existing set" "#{1 2 3}" "(persistent! (conj! (transient #{1 2}) 3))"]
|
|
["contains?" "true" "(contains? (transient #{1 2}) 1)"]
|
|
["count" "2" "(count (transient #{1 2}))"]
|
|
["persistent! is a set" "true" "(set? (persistent! (transient #{1})))"]
|
|
["map elements by value" "1" "(count (persistent! (conj! (transient #{}) {:a 1} (hash-map :a 1))))"])
|
|
|
|
(defspec "transient / immutability of source"
|
|
["source vector unchanged" "true"
|
|
"(let [v [1 2 3] _ (persistent! (conj! (transient v) 4))] (= v [1 2 3]))"]
|
|
["source map unchanged" "true"
|
|
"(let [m {:a 1} _ (persistent! (assoc! (transient m) :b 2))] (= m {:a 1}))"])
|
|
|
|
# Transients are invokable for read-only lookup, like their persistent forms.
|
|
(defspec "transient / invokable lookup"
|
|
["vector index" "20" "((transient [10 20 30]) 1)"]
|
|
["map key as fn" "7" "((transient {:x 7}) :x)"]
|
|
["map key default" "99" "((transient {:x 7}) :z 99)"]
|
|
["keyword on transient" "7" "(:x (transient {:x 7}))"]
|
|
["set membership" "2" "((transient #{1 2 3}) 2)"]
|
|
["set miss default" ":no" "((transient #{1 2 3}) 42 :no)"]
|
|
["collection key" ":v" "((transient {[1 2] :v}) [1 2])"])
|
|
|
|
# assoc! (unlike assoc) accepts an odd arg count — a missing final value is nil.
|
|
# (A struct literal can't express an explicit nil value, so assert via contains?.)
|
|
(defspec "transient / assoc! odd args"
|
|
["odd arg key present" "true"
|
|
"(contains? (persistent! (assoc! (transient {}) :a 1 :b)) :b)"]
|
|
["odd arg value is nil" "true"
|
|
"(nil? (get (persistent! (assoc! (transient {}) :a 1 :b)) :b))"]
|
|
["odd arg keeps prior" "1"
|
|
"(get (persistent! (assoc! (transient {}) :a 1 :b)) :a)"]
|
|
["vector odd arg" "[9 nil]"
|
|
"(persistent! (apply assoc! (transient []) [0 9 1]))"])
|
|
|
|
# Using a transient after persistent! (or popping an empty one) throws.
|
|
(defspec "transient / invalidation"
|
|
["conj! after persistent!" :throws
|
|
"(let [t (transient [])] (persistent! t) (conj! t 1))"]
|
|
["assoc! after persistent!" :throws
|
|
"(let [t (transient {})] (persistent! t) (assoc! t :a 1))"]
|
|
["persistent! twice" :throws
|
|
"(let [t (transient [])] (persistent! t) (persistent! t))"]
|
|
["pop! empty" :throws "(pop! (transient []))"])
|