From ea520547858ba7f2da817ed634c3b984fd7bc19a Mon Sep 17 00:00:00 2001
From: Simon Brooke <simon@journeyman.cc>
Date: Tue, 18 Aug 2020 11:26:37 +0100
Subject: [PATCH 1/3] Upgraded to clj-jgit 1.0.0; not yet working.

---
 project.clj             |  2 +-
 src/smeagol/history.clj | 14 ++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/project.clj b/project.clj
index 083ca2a..c55a4d5 100644
--- a/project.clj
+++ b/project.clj
@@ -3,7 +3,7 @@
   :url "https://github.com/simon-brooke/smeagol"
   :license {:name "GNU General Public License,version 2.0 or (at your option) any later version"
             :url "https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html"}
-  :dependencies [[clj-jgit "0.8.10"]
+  :dependencies [[clj-jgit "1.0.0"]
                  [clj-yaml "0.4.0"]
                  [clojure.java-time "0.3.2"]
                  [com.cemerick/url "0.1.1"]
diff --git a/src/smeagol/history.clj b/src/smeagol/history.clj
index e567db3..42eaa49 100644
--- a/src/smeagol/history.clj
+++ b/src/smeagol/history.clj
@@ -6,11 +6,17 @@
             [clj-jgit.querying :as q]
             [taoensso.timbre :as log])
   (:import  [org.eclipse.jgit.api Git]
-            [org.eclipse.jgit.lib Repository ObjectId]
-            [org.eclipse.jgit.revwalk RevCommit RevTree RevWalk]
-            [org.eclipse.jgit.treewalk TreeWalk AbstractTreeIterator CanonicalTreeParser]
+            [org.eclipse.jgit.lib 
+             ;; Repository
+             ObjectId]
+            ;; [org.eclipse.jgit.revwalk RevCommit RevTree RevWalk]
+            [org.eclipse.jgit.treewalk TreeWalk
+             ;; AbstractTreeIterator 
+             CanonicalTreeParser]
             [org.eclipse.jgit.treewalk.filter PathFilter]
-            [org.eclipse.jgit.diff DiffEntry DiffFormatter]))
+            [org.eclipse.jgit.diff 
+             ;; DiffEntry 
+             DiffFormatter]))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;;;

From f9587f1e1608593d5c4806db7df40879ae7b7d4b Mon Sep 17 00:00:00 2001
From: Simon Brooke <simon@journeyman.cc>
Date: Tue, 18 Aug 2020 17:40:36 +0100
Subject: [PATCH 2/3] #22: H'mmm, clj-git API has changed considerably.

This isn't working, but does compile. More work needed.
---
 src/smeagol/history.clj     |  4 ++--
 src/smeagol/routes/wiki.clj |  2 +-
 src/smeagol/util.clj        | 10 ++++++----
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/smeagol/history.clj b/src/smeagol/history.clj
index 42eaa49..3e38e3c 100644
--- a/src/smeagol/history.clj
+++ b/src/smeagol/history.clj
@@ -61,9 +61,9 @@
     (git/load-repo git-directory-path)
     (catch java.io.FileNotFoundException fnf
       (log/info "Initialising Git repository at" git-directory-path)
-      (git/git-init git-directory-path)
+      (git/git-init :dir git-directory-path)
       (let [repo (git/load-repo git-directory-path)]
-        (git/git-add-and-commit repo "Initial commit")
+        (git/git-commit repo "Initial commit")
         repo))))
 
 
diff --git a/src/smeagol/routes/wiki.clj b/src/smeagol/routes/wiki.clj
index e5ae10a..876fe87 100644
--- a/src/smeagol/routes/wiki.clj
+++ b/src/smeagol/routes/wiki.clj
@@ -75,7 +75,7 @@
     (log/info (format "Saving %s's changes ('%s') to %s in file '%s'" user summary page file-path))
     (spit file-path source-text)
     (git/git-add git-repo file-name)
-    (git/git-commit git-repo summary {:name user :email email})
+    (git/git-commit git-repo summary :name user :email email)
     (response/redirect
       (str
         "/wiki?page="
diff --git a/src/smeagol/util.clj b/src/smeagol/util.clj
index ec37e06..1587f5b 100644
--- a/src/smeagol/util.clj
+++ b/src/smeagol/util.clj
@@ -79,15 +79,15 @@
                (cjio/file local-url-base file-path))]
     (cond
       (cs/includes? file-path "..")
-      (cs/join " " file-path
-               "Attempts to ascend the file hierarchy are disallowed.")
+      (cs/join " " [file-path
+                    "Attempts to ascend the file hierarchy are disallowed."])
       (not (cs/starts-with? path local-url-base))
       (cs/join " " [path "is not servable"])
       (not (fs/exists? path))
       (cs/join " " [path "does not exist"])
       (not (fs/readable? path))
       (cs/join " " [path "is not readable"])))
-    (catch Exception any (cs/join " " file-path "is not servable because" (.getMessage any)))))
+    (catch Exception any (cs/join " " [file-path "is not servable because" (.getMessage any)]))))
 
 
 ;; (not-servable-reason "/home/simon/workspace/smeagol/resources/public/content/vendor/node_modules/photoswipe/dist/photoswipe.min.js")
@@ -157,8 +157,10 @@
 
 
 (defn get-servlet-context-path
+  "Return the servlet context path, if we're running as a servlet; if
+   not, return `nil`."
   [request]
-  (if-let [context (:servlet-context request)]
+  (when-let [context (:servlet-context request)]
     ;; If we're not inside a serlvet environment (for
     ;; example when using mock requests), then
     ;; .getContextPath might not exist

From c217a8381db1cb94232b400b3b63232c2e1b354d Mon Sep 17 00:00:00 2001
From: Simon Brooke <simon@journeyman.cc>
Date: Wed, 2 Sep 2020 14:14:33 +0100
Subject: [PATCH 3/3] Reopenable photoswipe galleries (bug)

Previously, a closed photoswipe gallery could not be reopened. Fixed.
---
 .gitignore                                    |   2 +-
 .../html-includes/photoswipe-boilerplate.html | 120 +++++++++++-------
 src/smeagol/extensions/photoswipe.clj         |  30 +----
 src/smeagol/repl.clj                          |   5 +-
 4 files changed, 87 insertions(+), 70 deletions(-)

diff --git a/.gitignore b/.gitignore
index ea914ae..777d72f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,7 +17,7 @@ pom.xml.asc
 smeagol.log*
 /node_modules/
 .DS_Store
-
+/.calva
 
 resources/public/content/uploads/
 
diff --git a/resources/public/html-includes/photoswipe-boilerplate.html b/resources/public/html-includes/photoswipe-boilerplate.html
index 2dec488..aa53882 100644
--- a/resources/public/html-includes/photoswipe-boilerplate.html
+++ b/resources/public/html-includes/photoswipe-boilerplate.html
@@ -1,65 +1,97 @@
-<!-- this is the whole of the photoswipe boilerplate as documented
-    [here](https://photoswipe.com/documentation/getting-started.html) with the
-    outermost div removed; it is supplied by the function
-    `smeagol.extensions.photoswipe/photoswipe-processor`, q.v. -->
-    <!-- Background of PhotoSwipe.
-         It's a separate element as animating opacity is faster than rgba(). -->
-    <div class="pswp__bg"></div>
+<div class="gallery" id="gallery{{index}}">
+    <div class="pswp" id="pswp-{{index}}" tabindex="-1" role="dialog" aria-hidden="true">
 
-    <!-- Slides wrapper with overflow:hidden. -->
-    <div class="pswp__scroll-wrap">
+        <!-- this is the whole of the photoswipe boilerplate as documented
+            [here](https://photoswipe.com/documentation/getting-started.html) with the
+            outermost div removed; it is supplied by the function
+            `smeagol.extensions.photoswipe/photoswipe-processor`, q.v. -->
+        <!-- Background of PhotoSwipe.
+                It's a separate element as animating opacity is faster than rgba(). -->
+        <div class="pswp__bg"></div>
 
-        <!-- Container that holds slides.
-            PhotoSwipe keeps only 3 of them in the DOM to save memory.
-            Don't modify these 3 pswp__item elements, data is added later on. -->
-        <div class="pswp__container">
-            <div class="pswp__item"></div>
-            <div class="pswp__item"></div>
-            <div class="pswp__item"></div>
-        </div>
+        <!-- Slides wrapper with overflow:hidden. -->
+        <div class="pswp__scroll-wrap">
 
-        <!-- Default (PhotoSwipeUI_Default) interface on top of sliding area. Can be changed. -->
-        <div class="pswp__ui pswp__ui--hidden">
+            <!-- Container that holds slides.
+                    PhotoSwipe keeps only 3 of them in the DOM to save memory.
+                    Don't modify these 3 pswp__item elements, data is added later on. -->
+            <div class="pswp__container">
+                <div class="pswp__item"></div>
+                <div class="pswp__item"></div>
+                <div class="pswp__item"></div>
+            </div>
 
-            <div class="pswp__top-bar">
+            <!-- Default (PhotoSwipeUI_Default) interface on top of sliding area. Can be changed. -->
+            <div class="pswp__ui pswp__ui--hidden">
 
-                <!--  Controls are self-explanatory. Order can be changed. -->
+                <div class="pswp__top-bar">
 
-                <div class="pswp__counter"></div>
+                    <!--  Controls are self-explanatory. Order can be changed. -->
 
-                <button class="pswp__button pswp__button--close" title="Close (Esc)"></button>
+                    <div class="pswp__counter"></div>
 
-                <button class="pswp__button pswp__button--share" title="Share"></button>
+                    <button class="pswp__button pswp__button--close" title="Close (Esc)"></button>
 
-                <button class="pswp__button pswp__button--fs" title="Toggle fullscreen"></button>
+                    <button class="pswp__button pswp__button--share" title="Share"></button>
 
-                <button class="pswp__button pswp__button--zoom" title="Zoom in/out"></button>
+                    <button class="pswp__button pswp__button--fs" title="Toggle fullscreen"></button>
 
-                <!-- Preloader demo https://codepen.io/dimsemenov/pen/yyBWoR -->
-                <!-- element will get class pswp__preloader--active when preloader is running -->
-                <div class="pswp__preloader">
-                    <div class="pswp__preloader__icn">
-                      <div class="pswp__preloader__cut">
-                        <div class="pswp__preloader__donut"></div>
-                      </div>
+                    <button class="pswp__button pswp__button--zoom" title="Zoom in/out"></button>
+
+                    <!-- Preloader demo https://codepen.io/dimsemenov/pen/yyBWoR -->
+                    <!-- element will get class pswp__preloader active when preloader is running -->
+                    <div class="pswp__preloader">
+                        <div class="pswp__preloader__icn">
+                            <div class="pswp__preloader__cut">
+                                <div class="pswp__preloader__donut"></div>
+                            </div>
+                        </div>
                     </div>
                 </div>
-            </div>
 
-            <div class="pswp__share-modal pswp__share-modal--hidden pswp__single-tap">
-                <div class="pswp__share-tooltip"></div>
-            </div>
+                <div class="pswp__share-modal pswp__share-modal--hidden pswp__single-tap">
+                    <div class="pswp__share-tooltip"></div>
+                </div>
 
-            <button class="pswp__button pswp__button--arrow--left" title="Previous (arrow left)">
-            </button>
+                <button class="pswp__button pswp__button--arrow--left" title="Previous (arrow left)">
+                </button>
 
-            <button class="pswp__button pswp__button--arrow--right" title="Next (arrow right)">
-            </button>
+                <button class="pswp__button pswp__button--arrow--right" title="Next (arrow right)">
+                </button>
+
+                <div class="pswp__caption">
+                    <div class="pswp__caption__center"></div>
+                </div>
 
-            <div class="pswp__caption">
-                <div class="pswp__caption__center"></div>
             </div>
 
         </div>
-
     </div>
+    <script>
+        //<![CDATA[
+        var gallery{{index}} = null;
+        var spec{{index}} = {{spec}};
+        var openGallery{{index}} = function() {
+            if (gallery{{index}}) {
+                try {
+                    gallery{{index}}.destroy();
+                }
+                catch (error) {
+                    console.error(error);
+                }
+            }
+            gallery{{index}} = new PhotoSwipe(document.getElementById("pswp-{{index}}"),
+                PhotoSwipeUI_Default,
+                spec{{index}}.slides,
+                    spec{{index}}.options);
+            gallery{{index}}.init();
+        };
+        if (spec{{index}}.openImmediately) {
+            openGallery{{index}}();
+        }
+        //]]>
+    </script>
+    <p>
+        <button id="open-gallery-{{index}}" onclick="openGallery{{index}}()">Open the gallery</button>
+    </p>
+</div>
\ No newline at end of file
diff --git a/src/smeagol/extensions/photoswipe.clj b/src/smeagol/extensions/photoswipe.clj
index 1330cf4..d30375a 100644
--- a/src/smeagol/extensions/photoswipe.clj
+++ b/src/smeagol/extensions/photoswipe.clj
@@ -9,6 +9,8 @@
             [instaparse.core :as insta]
             [me.raynes.fs :as fs]
             [noir.io :as io]
+            [selmer.parser :refer [render]]
+            [selmer.util :refer [without-escaping]]
             [smeagol.configuration :refer [config]]
             [smeagol.extensions.utils :refer :all]
             [smeagol.util :refer [content-dir upload-dir]]
@@ -41,31 +43,11 @@
   "Process a specification for a photoswipe gallery, using a JSON
   specification based on that documented on the Photoswipe website."
   [^String spec ^Integer index]
-  (str
-    "<div class='gallery'>
-    <div class=\"pswp\" id=\"pswp-"
-    index "\" tabindex=\"-1\" role=\"dialog\" aria-hidden=\"true\">\n"
+  (without-escaping
+   (render
     (slurp
-      (str (io/resource-path) "html-includes/photoswipe-boilerplate.html"))
-    "</div>
-    <p><button id=\"open-gallery-" index "\" onclick=\"gallery" index
-    ".init(); document.getElementById(`open-gallery-" index "`).style.display = 'none';\">Open the gallery</button></p>
-    <script>
-    \n//<![CDATA[\n
-    var pswpElement = document.getElementById('pswp-" index "');
-    var spec" index " = "
-    spec
-    ";
-    var gallery" index
-    " = new PhotoSwipe( pswpElement, PhotoSwipeUI_Default, spec"
-    index ".slides, spec" index ".options);
-    if (spec" index ".openImmediately) {
-    document.getElementById(`open-gallery-" index "`).style.display = 'none';
-    gallery" index ".init();
-    }
-    \n//]]\n
-    </script>
-    </div>"))
+     (str (io/resource-path) "html-includes/photoswipe-boilerplate.html"))
+    {:spec spec :index index})))
 
 
 (def simple-grammar
diff --git a/src/smeagol/repl.clj b/src/smeagol/repl.clj
index 58b3efb..d847e6a 100644
--- a/src/smeagol/repl.clj
+++ b/src/smeagol/repl.clj
@@ -45,7 +45,7 @@
 (defn start-server
   "used for starting the server in development mode from REPL"
   [& [port]]
-  (let [port (if port (Integer/parseInt port) 3000)]
+  (let [port (if port (Integer/parseInt (str port)) 3000)]
     (reset! server
             (serve (get-handler)
                    {:port port
@@ -58,3 +58,6 @@
 (defn stop-server []
   (.stop @server)
   (reset! server nil))
+
+;;(start-server 4444)
+