simon/jolt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

interop: String/valueOf static + String is a CharSequence

Browse source 
Two interop gaps surfaced bringing up hiccup and malli:
- String/valueOf(Object): hiccup's compiler stringifies attribute values with
  (String/valueOf (or arg "")). Added the static — "null" for nil, else core-str.
- (instance? CharSequence s) returned false for a string; String implements
  CharSequence, and malli's :re validator gates on it before matching, so :re
  schemas always failed. instance-check now answers true for strings.
This commit is contained in:
Yogthos 2026-06-15 15:15:32 -04:00
parent c22b23fb51
commit 60980df767
3 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/spec/host-interop-spec.janet
View file

@ -79,6 +79,14 @@
[".charAt" "\\b" "(.charAt \"abc\" 1)"]
[".equalsIgnoreCase" "true" "(.equalsIgnoreCase \"AbC\" \"aBc\")"]
["Long/MAX_VALUE" "true" "(pos? Long/MAX_VALUE)"]
# String/valueOf static (jolt-nkx): hiccup stringifies attribute values with it.
["String/valueOf num" "\"42\"" "(String/valueOf 42)"]
["String/valueOf str" "\"hi\"" "(String/valueOf \"hi\")"]
["String/valueOf kw" "\":k\"" "(String/valueOf :k)"]
["String/valueOf nil" "\"null\"" "(String/valueOf nil)"]
# String implements CharSequence (malli's :re gates on it, jolt-ltwk).
["instance? CharSequence" "true" "(instance? CharSequence \"aaa\")"]
["instance? CharSequence non-str" "false" "(instance? CharSequence 42)"]
["unsupported method throws" :throws "(.frobnicate \"abc\")"])
# java.time shims (jolt-ea7): epoch-ms backed values + a DateTimeFormatter